[exporter] internal/persistent_queue::OnProcessingFinished is changed to a class function instead of a callback #11338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #11338 +/- ##
==========================================
- Coverage 91.80% 91.79% -0.01%
==========================================
Files 432 432
Lines 20423 20426 +3
==========================================
+ Hits 18749 18751 +2
- Misses 1300 1301 +1
Partials 374 374 ☔ View full report in Codecov by Sentry. |
sfc-gh-sili
force-pushed
the
sili-queue-batcher-queue
branch
from
a71969d
to
220ff5e
Compare
sfc-gh-sili
force-pushed
the
sili-queue-batcher-queue
branch
from
220ff5e
to
3c3cace
Compare
dmitryax
approved these changes
Oct 4, 2024
Comment on lines
307
to
308
| // getNextItem pulls the next available item from the persistent storage along with a callback function that should be | ||
| // called after the item is processed to clean up the storage. If no new item is available, returns false. |
Co-authored-by: Dmitrii Anoshin <[email protected]>
|
Failing contrib tests are unrelated, broken on main |
jackgopack4
pushed a commit
to jackgopack4/opentelemetry-collector
that referenced
this pull request
Oct 8, 2024
… to a class function instead of a callback (open-telemetry#11338) #### Description Why this change? Each request from the queue contains multiple items, and those items could be merge-split into multiple batches when they are sent out (see open-telemetry#8122 for more about exporter batcher). We would like to book-keep those cases, and only call `onProcessingFinished` when all such batches has gone out. In this PR, `onProcessingFinished` is changed from a callback to a method function because it is easier to book keep index instead of functions. #### Link to tracking issue open-telemetry#8122 open-telemetry#10368 #### Testing `exporter/internal/queue/persistent_queue_test.go` #### Documentation This is an internal change invisible to the users. --------- Co-authored-by: Dmitrii Anoshin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Why this change?
Each request from the queue contains multiple items, and those items could be merge-split into multiple batches when they are sent out (see #8122 for more about exporter batcher). We would like to book-keep those cases, and only call
onProcessingFinishedwhen all such batches has gone out. In this PR,onProcessingFinishedis changed from a callback to a method function because it is easier to book keep index instead of functions.Link to tracking issue
#8122
#10368
Testing
exporter/internal/queue/persistent_queue_test.goDocumentation
This is an internal change invisible to the users.